Skip to content

feat: add support for Python 3.11 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 10, 2022
Merged

feat: add support for Python 3.11 #466

merged 9 commits into from
Nov 10, 2022

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Nov 8, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #467 🦕

@ziegenberg ziegenberg requested review from a team as code owners November 8, 2022 22:47
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 8, 2022
@ziegenberg ziegenberg force-pushed the add-python-3-11-support branch from acb6f92 to 6275bb5 Compare November 8, 2022 22:48
@dandhlee
Copy link
Contributor

dandhlee commented Nov 9, 2022

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

@ziegenberg
Copy link
Contributor Author

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

That's right; I do work with Google. I will open an issue.

I followed #284 when creating this PR, which also did not have an accompanying issue.

@ziegenberg ziegenberg force-pushed the add-python-3-11-support branch from 6275bb5 to 6556f1b Compare November 9, 2022 22:37
@ziegenberg
feat: add support for Python 3.11
34b87dc 
Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the add-python-3-11-support branch from 6556f1b to 34b87dc Compare November 9, 2022 22:38
@ziegenberg
Copy link
Contributor Author

The python -m py.test call had to be changed to python -m pytest, otherwise it would always fail with:

Error while finding module specification for 'py.test' (ModuleNotFoundError: __path__ attribute not found on 'py' while trying to find 'py.test')

@ziegenberg
Copy link
Contributor Author

If it's okay with you, I would rebase my PR onto the current main. That should solve the Commit message did not follow Conventional Commits error.

parthea
parthea reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@parthea parthea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the minimum version of grpcio is 1.49.1 for python 3.11. I've updated the setup.py to reflect that.

@parthea parthea changed the title add support for Python 3.11 feat: add support for Python 3.11 Nov 10, 2022
@parthea parthea merged commit ff379e3 into googleapis:main Nov 10, 2022
@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
@parthea
Copy link
Collaborator

parthea commented Nov 10, 2022

Thanks @ziegenberg!

@ziegenberg ziegenberg deleted the add-python-3-11-support branch November 10, 2022 16:42
This was referenced May 30, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for Python 3.11
3 participants
@ziegenberg @dandhlee @parthea